👋 @dmitrijrub @mikakesan Since you helped us test proxy functionality (#99) when we added support for it in #102, would you be willing to help us test this branch (134-remove-custom-proxy-functionality) to ensure you're still able to use this action with a proxy? 🙏

hi @parkerbxyz, what are the changes? should I just use uses: actions/create-github-app-token@134-remove-custom-proxy-functionality ?

should I just use uses: actions/create-github-app-token@134-remove-custom-proxy-functionality ?

Yes, exactly! 🙂

hmmm, looks like its failing

Run actions/create-github-app-token@134-remove-custom-proxy-functionality
owner and repositories not set, creating token for the current repository ("dt-arc")
Failed to create token for "dt-arc" (attempt 1): Connect Timeout Error
Failed to create token for "dt-arc" (attempt 2): Connect Timeout Error
Failed to create token for "dt-arc" (attempt 3): Connect Timeout Error
Failed to create token for "dt-arc" (attempt 4): Connect Timeout Error
RequestError [HttpError]: Connect Timeout Error
    at /home/runner/_work/_actions/actions/create-github-app-token/134-remove-custom-proxy-functionality/dist/main.cjs:3[7](https://github.com/company-company/dt-arc/actions/runs/9512488741/job/26317660736#step:10:8)097:11
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async hook4 (/home/runner/_work/_actions/actions/create-github-app-token/134-remove-custom-proxy-functionality/dist/main.cjs:39469:1[8](https://github.com/org-company/dt-arc/actions/runs/9512488741/job/26317660736#step:10:9))
    at async getTokenFromRepository (/home/runner/_work/_actions/actions/create-github-app-token/134-remove-custom-proxy-functionality/dist/main.cjs:3[9](https://github.com/telia-company/dt-arc/actions/runs/9512488741/job/26317660736#step:10:10)783:20)
    at async RetryOperation._fn (/home/runner/_work/_actions/actions/create-github-app-token/134-remove-custom-proxy-functionality/dist/main.cjs:39660:24) {
  status: 500,
  request: {
    method: 'GET',
    url: xxxx
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'actions/create-github-app-token',
      authorization: 'bearer [REDACTED]'
    },
    request: {
      fetch: [AsyncFunction: fetch],
      hook: [Function: bound hook4] AsyncFunction
    }
  },
  response: undefined,
  attemptNumber: 4,
  retriesLeft: 0
}
Error: Connect Timeout Error

Noting this in case it is helpful later: nodejs/undici#1650 (comment)

hmmm, looks like its failing

Thank you so much for testing that, @dmitrijrub! I've made some changes in hopes of fixing the failure you encountered. Would you mind testing again and letting us know how it goes, please? 🙏

Tests are currently failing due to our current use of the global dispatcher in our tests and local dispatcher in the fetch method. The problem can be reproduced with the following example:

import { EnvHttpProxyAgent, MockAgent, setGlobalDispatcher } from "undici";

const mockAgent = new MockAgent();
mockAgent.disableNetConnect();
setGlobalDispatcher(mockAgent);
const mockPool = mockAgent.get("https://example.test");

mockPool
  .intercept({
    path: `/`,
    method: "GET",
  })
  .reply(200);

await fetch("https://example.test", {
  // Comment out the following line to see the test succeed
  dispatcher: new EnvHttpProxyAgent(),
});

console.log("OK");

The global dispatcher is not being used when a local dispatcher is set. We need to verify if this is a feature or a bug.

The global dispatcher is not being used when a local dispatcher is set. We need to verify if this is a feature or a bug.

nodejs/undici#3792

Deno appears to have native proxy support: https://docs.deno.com/runtime/reference/env_variables/#special-environment-variables

Deno appears to have native proxy support

I'm down for using Deno instead of Node.js, as long as we still generate the built files with all dependencies and execute that code instead of loading dependencies dynamically at run time.

I just received a really helpful PR here: peter-evans/create-pull-request#3475

And that lead me to realise that proxy support can be simplified to this: peter-evans/create-pull-request#3483

It passes the proxy support tests I have, so looks good.

Just thought I would mention this in case it helps here.

Thank you @peter-evans! It looks like you use node-fetch-native as a dependency which depends on node-fetch, which is a huge dependency. We try to keep this action slim, so I'd like to avoid that.

We are interested in your test setup though and couldn't quite figure it out. Can you give us some pointers how you test the env-based proxy handling?

It looks like you use node-fetch-native as a dependency which depends on node-fetch, which is a huge dependency. We try to keep this action slim, so I'd like to avoid that.

I see. Well I'm interested to see what solution you end up with here then.

We are interested in your test setup though and couldn't quite figure it out. Can you give us some pointers how you test the env-based proxy handling?

I created a small docker image to launch a forward proxy based on glider. In the test, I start the forward proxy and then configure the firewall on the actions runner. The firewall settings deny outgoing, except through the proxy. So it makes sure that the action is definitely using the proxy when it's configured.

It looks like Node.js v24 is going to include proxy support:

• http: support HTTP[S]_PROXY environment variables in fetch nodejs/node#57165
• 2025-05-06, Version 24.0.0 (Current) nodejs/node#57609

🎉 This PR is included in version 3.0.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Unfortunately, even with Node 24, it's not working out of the box. Now NODE_USE_ENV_PROXY needs to be set to 1 to enable the automated proxy behavior. Setting process.env.NODE_USE_ENV_PROXY='1' in the code does not work.

We see two ways to support the proxy behavior

1. We ask users to set

      env:
        NODE_USE_ENV_PROXY: 1

2. We spawn a subprocess in which we can set NODE_USE_ENV_PROXY=1 on startup which makes it work, but it feels quite hacky

import { spawn } from "child_process";

run();

async function run() {
  if (
    !process.env.NODE_USE_ENV_PROXY &&
    (process.env.HTTP_PROXY || process.env.HTTPS_PROXY)
  ) {
    // spawn itself with NODE_USE_ENV_PROXY=1
    const child = spawn(process.execPath, process.argv.slice(1), {
      env: { ...process.env, NODE_USE_ENV_PROXY: "1" },
      stdio: "inherit",
    });
    child.on("exit", (code) => process.exit(code));
    return;
  }

  const response = await fetch("https://example.com");
  console.log(await response.text());
}